Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: xmlrpc protocol detection ......................................................................
Patch Set 6: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/28507/6/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 254: Line 255: class ConnectedSimpleXmlRPCServer(ConnectedTCPServer, Line 256: SimpleXMLRPCDispatcher): Line 257: """ Line 258: Code based on Python 2.7's SimpleXMLRPCServer.SimpleXMLRPCServer.__init__ now that you've dropped the close-on-exec code, comment is not so important... but never mind. Line 259: """ Line 260: Line 261: def __init__(self, requestHandler, logRequests=True, allow_none=False, Line 262: encoding=None): -- To view, visit http://gerrit.ovirt.org/28507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72819cc0ab5bde0150456263ab7dd1a5e99abfeb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
