Francesco Romani has posted comments on this change. Change subject: LiveMerge: Add merge verb and related machinery ......................................................................
Patch Set 5: Code-Review+1 (2 comments) I guess the TODO left in the code are gonna be addressed by followup patches in the series. If that's the case, it's good for me (+1). Please address my (very minor) comments in followup patches, do not waste time changing this one. http://gerrit.ovirt.org/#/c/26635/5/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 6948: # Line 6949: # @jobUUID: #optional Assign a UUID to this operation which can be used Line 6950: # to identify it in @VmStats Line 6951: # Line 6952: # Since: 4.12.0 4.15.0 Line 6953: ## Line 6954: {'command': {'class': 'VM', 'name': 'merge'}, Line 6955: 'data': {'vmID': 'UUID', 'drive': 'DriveSpecVolume', 'baseVolUUID': 'UUID', Line 6956: 'topVolUUID': 'UUID', '*bandwidth': 'int', '*jobUUID': 'UUID'}} http://gerrit.ovirt.org/#/c/26635/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5234: try: Line 5235: ret = self._dom.blockCommit(drive.path, base, top, bandwidth, Line 5236: flags) Line 5237: if ret != 0: Line 5238: raise RuntimeError("blockCommit operation failed rc:%i", ret) Maybe a new specific exception here, too? Line 5239: except (RuntimeError, libvirt.libvirtError): Line 5240: self.log.error("Live merge failed for '%s'", drive.path, Line 5241: exc_info=True) Line 5242: self.untrackBlockJob(jobUUID) -- To view, visit http://gerrit.ovirt.org/26635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I077e1bdf0130ebdc218135ca717a6a810bbab12c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
