Dan Kenigsberg has posted comments on this change. Change subject: LiveMerge: Add merge verb and related machinery ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/26635/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 30: import tempfile Line 31: import threading Line 32: import time Line 33: import xml.dom.minidom Line 34: import json we're making the not-quite sorted list even worse. Line 35: import uuid Line 36: Line 37: # 3rd party libs imports Line 38: import libvirt Line 5260: flags) Line 5261: if ret != 0: Line 5262: raise RuntimeError("blockCommit operation failed rc:%i", ret) Line 5263: except (RuntimeError, libvirt.libvirtError): Line 5264: self.log.error("Live merge failed for '%s'", drive.path, Federico, what about your favorite exception()? Line 5265: exc_info=True) Line 5266: self.untrackBlockJob(jobUUID) Line 5267: return errCode['mergeErr'] Line 5268: -- To view, visit http://gerrit.ovirt.org/26635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I077e1bdf0130ebdc218135ca717a6a810bbab12c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
