Francesco Romani has posted comments on this change. Change subject: LiveMerge: Add merge verb and related machinery ......................................................................
Patch Set 7: Code-Review+1 (1 comment) Minor nit, I don't mind if it's fixed with later patch (to avoid to waste Federico's +2) http://gerrit.ovirt.org/#/c/26635/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1673: Line 1674: BlockJobTypeMap = {libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_UNKNOWN: 'unknown', Line 1675: libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_PULL: 'pull', Line 1676: libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_COPY: 'copy', Line 1677: libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_COMMIT: 'commit'} please RENAME_IT_TO_MAKE_IT_LOOK_LIKE_A_CONSTANT Line 1678: Line 1679: def _makeDeviceDict(self): Line 1680: return dict((dev, []) for dev, _ in self.DeviceMapping) Line 1681: -- To view, visit http://gerrit.ovirt.org/26635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I077e1bdf0130ebdc218135ca717a6a810bbab12c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
