Dima Kuznetsov has posted comments on this change.
Change subject: vdsClient: alternative ways to provide password
......................................................................
Patch Set 16:
Here is the (old) usage for setVmTicket:
setVmTicket <vmId> <password> <sec> [disconnect|keep|fail] [params={}]
where params={} could be substituted with:
{key1:value1,key2:value2,key3:{k:v,...}}
or
(domain|pool|image|volume):some_value,(domain|pool|image|volume):some_value
This is done by passing the arg to _parseDriveSpec.
These params go to before/after_set_vm_ticket hook. There are no shipped
implementations of the hook, so I have no idea if changing this format would
break compatibility for someone. I'm reluctant to change the parameter behavior.
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dima Kuznetsov <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
