Dima Kuznetsov has posted comments on this change. Change subject: vdsClient: alternative ways to provide password ......................................................................
Patch Set 16: Hey Alon, Currently params= argument cannot contain spaces and is limited to being the 5th argument, now, if we want to add another optional argument without forcing the user to supply any other optional arguments, positions of other optional arguments cannot remain fixed. This is ok though because we can guess what to do with each argument: * if it starts with auth= it is the authentication argument. * if it is 'disconnect', 'keep', or 'fail', it is the action argument. * otherwise we can assume it is the params= argument, because thats the only option left. -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
