Francesco Romani has posted comments on this change. Change subject: LiveMerge: Add block job info to VM stats ......................................................................
Patch Set 7: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26634/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1671: Line 1672: BlockJobTypeMap = {libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_UNKNOWN: 'unknown', Line 1673: libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_PULL: 'pull', Line 1674: libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_COPY: 'copy', Line 1675: libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_COMMIT: 'commit'} Please RENAME_IT_TO_MAKE_IT_LOOKS_LIKE_A_CONSTANT It's fine to do it in a later trivial patch to not waste Federico's +2. Line 1676: Line 1677: def _makeDeviceDict(self): Line 1678: return dict((dev, []) for dev, _ in self.DeviceMapping) Line 1679: -- To view, visit http://gerrit.ovirt.org/26634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7278c0f06a2a06c8a8d680cf64746de3f73a389 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
