mooli tayer has posted comments on this change. Change subject: configurator.py: Node unpersist must be called before removing a file. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28821/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 320: delete a file if it exists. Line 321: """ Line 322: try: Line 323: if utils.isOvirtNode(): Line 324: NodeCfg().unpersist(content['path']) On verification I will need to test if unpersist() is ok with non existing files. Line 325: Line 326: os.unlink(content['path']) Line 327: except OSError as e: Line 328: if e.errno != errno.ENOENT: -- To view, visit http://gerrit.ovirt.org/28821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
