Antoni Segura Puimedon has posted comments on this change. Change subject: configurator.py: Node unpersist must be called before removing a file. ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28821/2/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 1: # Copyright 2013 Red Hat, Inc. 2013-2014 Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or Line 318: """ Line 319: delete a file if it exists. Line 320: """ Line 321: if utils.isOvirtNode(): Line 322: NodeCfg().unpersist(content['path']) > This call is new, before that we used unpersist() + rmfile. Now you can use I'm with Douglas, it is better to use delete since that is what you end up doing in the end. Line 323: utils.rmFile(content['path']) Line 324: Line 325: def _unprefixAndRemoveSection(self, path): Line 326: """ -- To view, visit http://gerrit.ovirt.org/28821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
