Antoni Segura Puimedon has posted comments on this change. Change subject: configurator.py: Node unpersist must be called before removing a file. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28821/2/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 318: """ Line 319: delete a file if it exists. Line 320: """ Line 321: if utils.isOvirtNode(): Line 322: NodeCfg().unpersist(content['path']) > I'm with Douglas, it is better to use delete since that is what you end up Oh, and you should check the return value. If it is different than zero you should probably raise. Line 323: utils.rmFile(content['path']) Line 324: Line 325: def _unprefixAndRemoveSection(self, path): Line 326: """ -- To view, visit http://gerrit.ovirt.org/28821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
