Allon Mureinik has posted comments on this change. Change subject: fencing: Introduce getHostStatus internal API ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28873/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3615: rm.LockType.exclusive): Line 3616: self.domainMonitor.stopMonitoring(sdUUID) Line 3617: Line 3618: @public Line 3619: def getHostStatus(self, hostId): > Nicer but little too long. We can follow old-school conventions and call it getStatusOfHostWithRegardsToStorageWithAVeryLongNameToIgnoreAyalBaronAndHisSuit(self, hostId) More realistically how about doesMaintainStorage(hostId) ? Line 3620: """ Line 3621: Returns host status on monitored domains. Line 3622: Line 3623: Warning: Internal use only. -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
