Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostIdStatus API ......................................................................
Patch Set 2: > I have general comment. Do we return host or hostId status. In most of the > places you use hostId and in sd.py is host. Looks like inconsistency issue. > Does hostIds have status? The status returned is the host status returned by sanlock, using a host id parameter. sanlock api call is called get_hosts(), and this is why the lower level layers (clusterlock, sd, domainMonitor) use this name. The public API was also using this name (getHostStatus) but reviewers asked to change. I don't see an issue that public api use one name and internal apis different names, at leat of the internal usage is consistent. -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
