Adam Litke has posted comments on this change. Change subject: Live Merge: support active layer commit ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28598/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5670: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT Line 5671: try: Line 5672: self._dom.blockJobAbort(diskName, flags) Line 5673: except libvirt.libvirtError: Line 5674: self.log.error("Failed to perform pivot", exc_info=True) > ok, will investigate. This is happening in an event thread, not in response to a command so I don't think we want to make a return code here. Line 5675: Line 5676: def _onBlockJobEvent(self, diskName, blockJobType, status): Line 5677: def isActiveCommit(jobType, status): Line 5678: if status != libvirt.VIR_DOMAIN_BLOCK_JOB_READY: -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
