Francesco Romani has posted comments on this change. Change subject: Live Merge: support active layer commit ......................................................................
Patch Set 6: (1 comment) Thanks, looks nicer. Added another possible improvement suggestion. http://gerrit.ovirt.org/#/c/28598/6/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirtconnection.py: Line 179: conn.domainEventRegisterAny(None, Line 180: ev, Line 181: target.dispatchLibvirtEvents, Line 182: ev) Line 183: I think this case is special enough to deserve an explicit domainEventRegisterAny step here, without the variable (re)assignement and the ev < 0 check. It is not a big deal however, and the code as it is here is good enough for me. Your call. Line 184: # In case we're running into troubles with keeping the connections Line 185: # alive we should place here: Line 186: # conn.setKeepAlive(interval=5, count=3) Line 187: # However the values need to be considered wisely to not affect -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
