Adam Litke has posted comments on this change. Change subject: Live Merge: support active layer commit ......................................................................
Patch Set 6: -Verified (3 comments) http://gerrit.ovirt.org/#/c/28598/6//COMMIT_MSG Commit Message: Line 13: snapshot. Once the merge is complete an event is emitted. Vdsm Line 14: triggers the second phase of the job by calling the blockJobAbort Line 15: function with a special PIVOT flag which instructs libvirt to pivot the Line 16: disk from the active layer to the base. Once this is complete, another Line 17: event is sent and vdsm must then handle synchronization as per usual. > what happens if we die before we handle the first event? Do you plan a fol Ahh, good catch. There are a couple of ways to handle this. We could check blockJob status on all disks during VM recovery and abort any jobs in READY state (which would fail the merge and require it to be retried). We could also try to handle them but I will have to think carefully about a few corner cases. Line 18: Line 19: This patch depends on currently unreleased libvirt and qemu features Line 20: that are targeted for a near term release. Line 21: http://gerrit.ovirt.org/#/c/28598/6/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirtconnection.py: Line 30: Line 31: log = logging.getLogger() Line 32: Line 33: Line 34: # Recent versions of libvirt provide an improved block job event which passes > please state in which libvirt version precisely, or else this kludge is goi sure. It's going to be 1.2.6. Line 35: # the device name to tha callback rather than the path. This ensures that we Line 36: # are able to correlate the event to the correct VM Disk throughout all phases Line 37: # of a live merge job. Line 38: try: Line 179: conn.domainEventRegisterAny(None, Line 180: ev, Line 181: target.dispatchLibvirtEvents, Line 182: ev) Line 183: > I think that it would be clearer to define sure. I can do it that way. Line 184: # In case we're running into troubles with keeping the connections Line 185: # alive we should place here: Line 186: # conn.setKeepAlive(interval=5, count=3) Line 187: # However the values need to be considered wisely to not affect -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
