Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: add route retrieval capability ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27317/8/lib/vdsm/netlink/__init__.py File lib/vdsm/netlink/__init__.py: Line 27: import ethtool Line 28: Line 29: _POOL_SIZE = 5 Line 30: _NETLINK_ROUTE = 0 Line 31: AF_UNSPEC = 0 > already define in socket.AF_UNSPEC Done Line 32: CHARBUFFSIZE = 40 # Increased to fit IPv6 expanded representations Line 33: Line 34: Line 35: class NLSocketPool(object): http://gerrit.ovirt.org/#/c/27317/8/lib/vdsm/netlink/route.py File lib/vdsm/netlink/route.py: Line 24: from . import _ethtool_uses_libnl3, LIBNL_ROUTE, _nl_geterror, _pool Line 25: from . import _nladdr_to_str, _nlaf_to_str, _nlscope_to_str, AF_UNSPEC Line 26: from .link import _nl_link_cache, _link_index_to_name Line 27: Line 28: EXTRA_TABLE_FIELD = 252 > why do we want to make this public? Done Line 29: Line 30: Line 31: def iter_routes(): Line 32: """Generator that yields an information dictionary for each route in the -- To view, visit http://gerrit.ovirt.org/27317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
