Dan Kenigsberg has posted comments on this change. Change subject: netlink: add route retrieval capability ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27317/11/lib/vdsm/netlink/route.py File lib/vdsm/netlink/route.py: Line 25: from . import _ethtool_uses_libnl3, LIBNL_ROUTE, _nl_geterror, _pool Line 26: from . import _addr_to_str, _af_to_str, _scope_to_str Line 27: from .link import _nl_link_cache, _link_index_to_name Line 28: Line 29: _EXTRA_TABLE_FIELD = 252 I wonder where this number coming from? RT_TABLE_COMPAT=252? if so, please use a clearer name. Line 30: Line 31: Line 32: def iter_routes(): Line 33: """Generator that yields an information dictionary for each route in the -- To view, visit http://gerrit.ovirt.org/27317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
