Dan Kenigsberg has posted comments on this change.

Change subject: netlink: add route retrieval capability
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/27317/11/lib/vdsm/netlink/route.py
File lib/vdsm/netlink/route.py:

Line 53:     return {
Line 54:         'destination': _addr_to_str(_rtnl_route_get_dst(route)),  # 
network
Line 55:         'source': _addr_to_str(_rtnl_route_get_src(route)),
Line 56:         'gateway': _addr_to_str(_rtnl_route_get_gateway(route)),  # via
Line 57:         'oif': oif_label,
Consider not reporting oif/table if they are None
Line 58:         'table': table,
Line 59:         'family': _af_to_str(_rtnl_route_get_family(route)),
Line 60:         'scope': _scope_to_str(_rtnl_route_get_scope(route))}
Line 61: 


-- 
To view, visit http://gerrit.ovirt.org/27317
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to