Nir Soffer has posted comments on this change. Change subject: configurator.py: call Node's delete() for file deletion on node. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28821/3/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 320: """ Line 321: if utils.isOvirtNode(): Line 322: NodeCfg().delete(content['path']) Line 323: else: Line 324: utils.rmFile(content['path']) Just a note for a future improvement: this show that we need a similar object such as NodeCfg for non-node version, that provide methods like delete/unpersist, so this could would simply do: self.filesystem.delete(content['path'])) Line 325: Line 326: def _unprefixAndRemoveSection(self, path): Line 327: """ Line 328: undo changes done by _prefixAndPrepend. -- To view, visit http://gerrit.ovirt.org/28821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
