Nir Soffer has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/28817/15/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 485: Line 486: try: Line 487: params = req.params Line 488: server_address = ctx.client.socket.getsockname()[0] Line 489: self._bridge.registerContext(ClientContext(server_address)) This runs in the a request thread - right? Since we need only server address, we don't need the ClientContext class - we can simply register the server address. In the other side, the code in the bridge can use the server address. This is exactly what the xmlrpc does - why create more complexity? Line 490: if isinstance(req.params, list): Line 491: res = method(*params) Line 492: else: Line 493: res = method(**params) -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
