Nir Soffer has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
......................................................................
Patch Set 16: Code-Review-1
You get the active nic on for every request, but we need it only for one
request - this seems pointless and depending on the implementation, may be even
harmful - if this check breaks for some reason, then all vdsm request will
fail, instead of only getCaps.
And this is of course not compatible with the code in xmlrpc, which does get
the active nic only when handling getCaps request.
461 def getCapabilities(self):
462 api = API.Global()
463 ret = api.getCapabilities()
464 ret['info']['lastClient'] = self.cif.threadLocal.client
465 ret['info']['lastClientIface'] = getDeviceByIP(
466 self.cif.threadLocal.server)
So I suggest:
- Use bridge.threadLocal.server - just like xmlrpc
- Get the device name when handling getCapabilities in the bridge
If you think that threadLocal.server is not a good name, change also the name
used in xmlrpc. We want same hack in two places, not 2 different hacks.
--
To view, visit http://gerrit.ovirt.org/28817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
