Saggi Mizrahi has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc ......................................................................
Patch Set 16: (3 comments) Also, move the process of figuring out what the actual interface is to the getCaps call so we put the minimal amount of information in threadlocal http://gerrit.ovirt.org/#/c/28817/16/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 103: Line 104: def __init__(self, sock, reactor): Line 105: self._reactor = reactor Line 106: self._messageHandler = None Line 107: self.socket = sock You can't make the socket public as it breaks abstraction. I think you should just have self._socket.getsockname() available straight from here as StompServer.getLocalAddress() or something. Line 108: Line 109: adapter = StompAdapterImpl(reactor, self._handleMessage) Line 110: self._stompConn = _StompConnection( Line 111: adapter, Line 174: self._messageHandler = msgHandler Line 175: self.check_read() Line 176: Line 177: def check_read(self): Line 178: if hasattr(self._socket, 'pending') and self._socket.pending() > 0: Unrelated? Line 179: self._stompConn._dispatcher.handle_read() Line 180: Line 181: def send(self, message): Line 182: self._aclient.send(self._stompConn, _DEFAULT_REQUEST_DESTINATION, Line 262: self._map = {} Line 263: self._isRunning = False Line 264: self._wakeupEvent = _AsyncoreEvent(self._map) Line 265: Line 266: def createListener(self, connected_socket, acceptHandler): Unrelated? Line 267: listener = StompListener(self, acceptHandler, connected_socket) Line 268: self.wakeup() Line 269: return listener Line 270: -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
