Francesco Romani has posted comments on this change. Change subject: Add API.VM.setIoTune ......................................................................
Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/28714/22/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3824: dom.removeChild(io_dom_list[0]) Line 3825: io_dom = XMLElement("iotune") Line 3826: ioTuneValuesToDom(io_tune, io_dom) Line 3827: dom.appendChild(io_dom) Line 3828: found_device.specParams['ioTune'] = io_tune > Well dom here is the device's xml object reference or do you mean something I was too terse, sorry about that. Let me be more verbose. Devices have ac cached XML representation in the form of the _deviceXML attribute which needs to be kept in sync. See for example how hotplugDisk or hotplugNic behaves. Please note that this XML is fed to hook, so keeping stale data on it can lead do subtle bug. There are refactoring/cleanup patches in the queue but they aren't been merged yet, so we still need to ensure this cache is valid. Line 3829: Line 3830: return {'status': doneCode} Line 3831: Line 3832: def _createTransientDisk(self, diskParams): -- To view, visit http://gerrit.ovirt.org/28714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
