Francesco Romani has posted comments on this change. Change subject: Add API.VM.setIoTune ......................................................................
Patch Set 24: Code-Review+1 (1 comment) good enough for me. http://gerrit.ovirt.org/#/c/28714/24/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3836: Line 3837: # Make sure the cached XML representation is valid as well Line 3838: xml = found_device.getXML().toprettyxml(encoding='utf-8') Line 3839: self.log.debug("New device XML for %s: %s", Line 3840: found_device.name, xml) We need to be sure this will not spam the logs, but can be addressed in a future patch. Line 3841: found_device._deviceXML = xml Line 3842: Line 3843: return {'status': doneCode} Line 3844: -- To view, visit http://gerrit.ovirt.org/28714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
