Federico Simoncelli has posted comments on this change. Change subject: Live Merge: support active layer commit ......................................................................
Patch Set 7: Code-Review-1 (2 comments) Minor comment about documentation. http://gerrit.ovirt.org/#/c/28598/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5635: entry['cur'] = str(liveInfo['cur']) Line 5636: entry['end'] = str(liveInfo['end']) Line 5637: try: Line 5638: pivot = libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_ACTIVE_COMMIT Line 5639: pivot = 3 # XXX: workaround libvirt bug (wrong type) I don't think I get this. I'd expect this to be in the except part. Anyway can you document this better? what's the bug? Line 5640: except AttributeError: Line 5641: pivot = -1 Line 5642: # Is this an active layer merge which needs to be pivoted? Line 5643: if (liveInfo['cur'] == liveInfo['end'] and Line 5841: self.untrackBlockJob(jobID) Line 5842: except Exception: Line 5843: self.log.exception("Live merge cleanup failed") Line 5844: return False Line 5845: elif mode == 'pivot': Nice, cleaner than I thought. Line 5846: self.log.info("Requesting pivot to complete active layer commit " Line 5847: "(job %s)", jobID) Line 5848: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT Line 5849: try: -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
