Federico Simoncelli has posted comments on this change. Change subject: Live Merge: support active layer commit ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/28598/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5361: # block job. In the first phase, data is copied to base. Once Line 5362: # completed, an event is raised to indicate that the job has Line 5363: # transitioned to the second phase. We must then tell libvirt to Line 5364: # pivot to the new active layer (baseVolUUID). Line 5365: flags |= libvirt.VIR_DOMAIN_BLOCK_COMMIT_ACTIVE > caps.getLiveMergeSupport() guarantees that we have that flag then remove the check from line 5291 Line 5366: Line 5367: # Take the jobs lock here to protect the new job we are tracking from Line 5368: # being cleaned up by queryBlockJobs() since it won't exist right away Line 5369: with self._jobsLock: -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
