Dan Kenigsberg has posted comments on this change. Change subject: Live Merge: support active layer commit ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/28598/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5516: "(job %s)", jobID) Line 5517: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT Line 5518: try: Line 5519: self._dom.blockJobAbort(drive.name, flags) Line 5520: except libvirt.libvirtError: Why does libvirt.libvirtError need a special treatment? On any Exception, self.success would remain False, the exception would be logged by @utils.traceback, and a following queryBlockJobs() call. I think that the previous try-except (line 5511) should be dropped, too (from the previous patch). Line 5521: self.log.exception("Failed to perform pivot") Line 5522: return False Line 5523: else: Line 5524: raise RuntimeError("Invalid mode: '%s'" % mode) -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
