Dan Kenigsberg has posted comments on this change. Change subject: Live Merge: support active layer commit ......................................................................
Patch Set 14: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28598/14/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5312: entry['end'] = str(liveInfo['end']) Line 5313: if self._activeLayerCommitReady(liveInfo): Line 5314: try: Line 5315: self.handleBlockJobEvent(jobID, drive, 'pivot') Line 5316: except Exception: if @traceback is dropped from handleBlockJobEvent() as I suggest, please remember to move the exception() call to here. Line 5317: # Just log it. We will retry next time Line 5318: self.log.error("Pivot failed for job %s", jobID) Line 5319: else: Line 5320: # Libvirt has stopped reporting this job so we know it will -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
