Nir Soffer has posted comments on this change. Change subject: tests: introducing whitebox tests ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29745/4/tests/README File tests/README: Line 35: i.e. they actually open sockets, read files, write to storage, etc. This Line 36: contrasts with a unit test, in which external components should be mocked. It Line 37: also contrasts with the functional tests, in that the scope of code checked is Line 38: much smaller, and the test is aware of the underlying implementation (hence the Line 39: term "white" box, as opposed to "black" box). > I don't think so. What does it integrate? our python code with libguestfs? Whitebox test is a test poking into the internals, compared with blackbox test that use only public intefaces and does not know anything about the implementation. The alignment test is not a whitebox test - it is a blackbox test. You test a module using its public interface. The module happen to use libguestfs but we don't really care about this. If you mock libguestfs, this would be a whitebox test, since you assume the usage of libguestfs. The concept of whitebox/blackbox is not very interesting and not the main reason why this test should not be in the regular test suit. Line 40: -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
