Nir Soffer has posted comments on this change. Change subject: tests: introducing whitebox tests ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29745/5//COMMIT_MSG Commit Message: Line 18: because they are aware of the inside implementation (as opposed to Line 19: blackbox tests), but they check that things "really work" (e.g. Line 20: libraries get called, sockets are opened, etc.) , and not just Line 21: the internal logic of some small section of code (which would Line 22: characterize a unit test). > they main reason we don't like running this test is that it's slow. For slow tests we have the @slowtest decorator, but using it is not very easy (make check NOSE_SKIP_SLOW_TESTS=1). The issue is is not only the slowness but fact that this test both our code calling libguestfs, and libguestfs itself. So this may break even if our code did not change. There is not reason to run this test each time you build vdsm, it it relevant only when libguestfs or one of its dependencies changed, or if you modified this code. So we can call this "small" functional tests. Line 23: Line 24: Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
