Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29745/5//COMMIT_MSG Commit Message: Line 18: because they are aware of the inside implementation (as opposed to Line 19: blackbox tests), but they check that things "really work" (e.g. Line 20: libraries get called, sockets are opened, etc.) , and not just Line 21: the internal logic of some small section of code (which would Line 22: characterize a unit test). > I agree with another commenter that blackbox vs. whitebox isn't interesting they main reason we don't like running this test is that it's slow. so, how to call the new category? perhaps just "slowtests". Line 23: Line 24: Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
