Dan Kenigsberg has posted comments on this change. Change subject: packaging: Changes for official builds ......................................................................
Patch Set 2: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/30747/2/configure.ac File configure.ac: Line 148: # Network Line 149: AC_ARG_WITH( Line 150: [bridge-name], Line 151: [AS_HELP_STRING([--with-bridge-name=], Line 152: [name of bridge vdsm will use @<:@default=ovirtmgmt@:>@])], it's not a *py file, but tabs are still evil Line 153: , Line 154: [with_bridge_name='ovirtmgmt']) Line 155: AC_SUBST([VDSMBRIDGE], [${with_bridge_name}]) Line 156: http://gerrit.ovirt.org/#/c/30747/2/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 51: Line 52: # Line 53: # The username of SASL authenticating for libvirt connection Line 54: # Line 55: SASL_USERNAME = '@SASL_USERNAME@' do we really need this? I do not think that this should be configurable. We should create the new name on downstream upgrade of old machines. Line 56: Line 57: # This is the domain version translation list Line 58: # DO NOT CHANGE OLD VALUES ONLY APPEND Line 59: DOMAIN_VERSIONS = (0, 2, 3) http://gerrit.ovirt.org/#/c/30747/2/vds_bootstrap/Makefile.am File vds_bootstrap/Makefile.am: Line 22: Line 23: CLEANFILES = \ Line 24: deployUtil.py.in \ Line 25: deployUtil.py \ Line 26: vds_bootstrap.py While at it, add $(NULL) Line 27: Line 28: # Line 29: # NOTE: Line 30: # We keep old version to allow http://gerrit.ovirt.org/#/c/30747/2/vds_bootstrap/vds_bootstrap.py.in File vds_bootstrap/vds_bootstrap.py.in: Line 153: 'openssl.x86_64', 'rsync.x86_64') Line 154: Line 155: if rhel6based: Line 156: DEVEL_PACK = () Line 157: VDS_PACK = ('@QEMU_KVM_PKG@', 'qemu-kvm-tools', VDSM_NAME, no one uses this file outside d/s el6. you may hard-code qemu-kvm-rhev here, if you must. Line 158: VDSM_NAME + '-cli', 'libjpeg', 'spice-server', 'pixman', Line 159: 'seabios', '@QEMU_IMG_PKG@', 'fence-agents', Line 160: 'libselinux-python', 'sanlock', 'sanlock-python') Line 161: # Gluster packages http://gerrit.ovirt.org/#/c/30747/2/vdsm_reg/deployUtil.py.in File vdsm_reg/deployUtil.py.in: Line 85: ERR_NO_ROUTE = 7 Line 86: SCRIPT_NAME_ADD = "addNetwork" Line 87: SCRIPT_NAME_DEL = "delNetwork" Line 88: IFACE_CONFIG = "/etc/sysconfig/network-scripts/ifcfg-" Line 89: MGT_BRIDGE_NAME = "@VDSMBRIDGE@" I don't want to see this @VDSMBRIDGE@ upstream. vdsm-reg needs it only to register with ancient rhev-m-3.0 that are no longer supported here. Even if I'm forced to swallow this, please have it a separate patch that is easily revertible, and use a name like VDSM_REG_BRIDGE so that it is clear that no one else should ever use it. Line 90: REMOTE_SSH_KEY_FILE = ('/engine.ssh.key.txt', '/rhevm.ssh.key.txt') Line 91: CORE_DUMP_PATH = '/var/lib/vdsm/core' Line 92: CORE_PATTERN = '/proc/sys/kernel/core_pattern' Line 93: XML_QUOTES = { -- To view, visit http://gerrit.ovirt.org/30747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2854badc6b33073aa1d30e014172a3788057b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
