Yaniv Bronhaim has posted comments on this change. Change subject: packaging: Changes for official builds ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30747/2/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 51: Line 52: # Line 53: # The username of SASL authenticating for libvirt connection Line 54: # Line 55: SASL_USERNAME = '@SASL_USERNAME@' > do we really need this? I do not think that this should be configurable. We i don't understand, why not to configure it specifically in spec file if we don't use the default user (vdsm@ovirt) ? Line 56: Line 57: # This is the domain version translation list Line 58: # DO NOT CHANGE OLD VALUES ONLY APPEND Line 59: DOMAIN_VERSIONS = (0, 2, 3) -- To view, visit http://gerrit.ovirt.org/30747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2854badc6b33073aa1d30e014172a3788057b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
