Alon Bar-Lev has posted comments on this change. Change subject: packaging: Changes for official builds ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/30747/2/configure.ac File configure.ac: Line 166: # SMBIOS names Line 167: AC_ARG_WITH( Line 168: [smbios-manufacturer], Line 169: [AS_HELP_STRING([--with-smbios-manufacturer=], Line 170: [SMBIOS MANUFACTURER name @<:@default=oVirt@:>@])], no need for trailing =, unless you use some term, such as =XXX why MANUFACTURER in capital? Line 171: , Line 172: [with_smbios_manufacturer='oVirt']) Line 173: AC_SUBST([SMBIOS_MANUFACTURER], [${with_smbios_manufacturer}]) Line 174: http://gerrit.ovirt.org/#/c/30747/2/vds_bootstrap/Makefile.am File vds_bootstrap/Makefile.am: Line 22: Line 23: CLEANFILES = \ Line 24: deployUtil.py.in \ Line 25: deployUtil.py \ Line 26: vds_bootstrap.py I think variables can be taken out of deployUtil.in, as vds_bootstrap already reads it. Line 27: Line 28: # Line 29: # NOTE: Line 30: # We keep old version to allow http://gerrit.ovirt.org/#/c/30747/2/vdsm_reg/deployUtil.py.in File vdsm_reg/deployUtil.py.in: Line 85: ERR_NO_ROUTE = 7 Line 86: SCRIPT_NAME_ADD = "addNetwork" Line 87: SCRIPT_NAME_DEL = "delNetwork" Line 88: IFACE_CONFIG = "/etc/sysconfig/network-scripts/ifcfg-" Line 89: MGT_BRIDGE_NAME = "@VDSMBRIDGE@" > I don't want to see this @VDSMBRIDGE@ upstream. vdsm-reg needs it only to r it is used in 3.1 as well, so we should remain it configurable, VDSM_REG_BRIDGE is good. Line 90: REMOTE_SSH_KEY_FILE = ('/engine.ssh.key.txt', '/rhevm.ssh.key.txt') Line 91: CORE_DUMP_PATH = '/var/lib/vdsm/core' Line 92: CORE_PATTERN = '/proc/sys/kernel/core_pattern' Line 93: XML_QUOTES = { -- To view, visit http://gerrit.ovirt.org/30747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2854badc6b33073aa1d30e014172a3788057b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
