Antoni Segura Puimedon has posted comments on this change. Change subject: networkTests: UNKNOWN operstate ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30787/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 172: changes = [(event.device, event.state) for event in monitor Line 173: if event.device == device] Line 174: for _, state in changes: Line 175: if originalState != state and not (originalState == 'UNKNOWN' and Line 176: state == 'UP'): This would not fail a sequence of changes ['UP', 'UNKNOWN', 'UP'] when it should ;-) Line 177: raise OperStateChangedError('%s operstate changed: %s -> %r' % Line 178: (device, originalState, changes)) Line 179: Line 180: -- To view, visit http://gerrit.ovirt.org/30787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
