Dan Kenigsberg has posted comments on this change. Change subject: networkTests: UNKNOWN operstate ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/30787/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-07-29 13:55:56 +0200 Line 6: Line 7: networkTests: UNKNOWN operstate Line 8: Line 9: Sometimes kernel is not fast enough to write new device's Could you explain when does this happen (which tests? which configurator?), as this may infer trouble elsewhere (e.g. assume Engine finds the interface in UNKNOWN operstate). Another problem with this patch is that we may theoretically have an existing "false positive": our tests pass, but only because interfaces are in UNKNOWN state; if they were initially up they might have changed state. Line 10: /sys/class/net/$devicename/operstate in time, in this case Line 11: originalState read by networkTests:nonChangingOperstate is Line 12: 'UNKNOWN' and test which it uses fails. Line 13: Line 10: /sys/class/net/$devicename/operstate in time, in this case Line 11: originalState read by networkTests:nonChangingOperstate is Line 12: 'UNKNOWN' and test which it uses fails. Line 13: Line 14: Condition change: State change from 'UNKNOWN' to 'UP' is ok. a *single* change state change from 'UNKNOWN' to 'UP' is ok. Line 15: Line 16: Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257 -- To view, visit http://gerrit.ovirt.org/30787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
