Dan Kenigsberg has posted comments on this change. Change subject: networkTests: UNKNOWN operstate ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30787/4//COMMIT_MSG Commit Message: Line 8: Line 9: Sometimes kernel is not fast enough to write new device's Line 10: /sys/class/net/$devicename/operstate in time, in this case Line 11: originalState read by networkTests:nonChangingOperstate is Line 12: 'UNKNOWN' and test which it uses fails. What if the kernel is sooo slow that it does not update the state AT ALL during the test? nonChangingOperstate() would pass, but prove nothing at all. I think we have a deeper problem here: setupNetworks returns before interfaces are UP. The kernel actions are async. Ok. Vdsm actions are async. Tolerable. But the test should not assume that the bond is up, while it isn't. Line 13: Line 14: Condition change: State change from 'UNKNOWN' to 'UP' is ok. Line 15: Line 16: This problem occurs with iproute2 on this tests: -- To view, visit http://gerrit.ovirt.org/30787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
