Alon Bar-Lev has posted comments on this change. Change subject: packaging: Changes for official builds ......................................................................
Patch Set 5: Code-Review+1 (1 comment) +1 for autotools http://gerrit.ovirt.org/#/c/30747/5/configure.ac File configure.ac: Line 191: AC_ARG_WITH( Line 192: [register-uri], Line 193: [AS_HELP_STRING([--with-register-uri=URI], Line 194: [registration URI on engine side Line 195: @<:@default=/OvirtEngineWeb/register@:>@])], are you sure this breakage of line does not effect --help? Line 196: [VDSM_REG_URI="${withval}"], Line 197: [VDSM_REG_URI="/OvirtEngineWeb/register"]) Line 198: AC_SUBST([VDSM_REG_URI]) Line 199: -- To view, visit http://gerrit.ovirt.org/30747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2854badc6b33073aa1d30e014172a3788057b5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
