Dima Kuznetsov has posted comments on this change. Change subject: packaging: Changes for official builds ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/30747/3/configure.ac File configure.ac: Line 151: [AS_HELP_STRING([--with-engine-name=NAME], Line 152: [name of the engine @<:@default=oVirt Engine@:>@])], Line 153: , Line 154: [with_engine_name='oVirt Engine']) Line 155: AC_SUBST([ENGINENAME], ["${with_engine_name}"]) > just recommendation... consider the following notation: Done Line 156: Line 157: # SMBIOS names Line 158: AC_ARG_WITH( Line 159: [smbios-manufacturer], -- To view, visit http://gerrit.ovirt.org/30747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2854badc6b33073aa1d30e014172a3788057b5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
