Alon Bar-Lev has posted comments on this change. Change subject: packaging: Changes for official builds ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/30747/4/configure.ac File configure.ac: Line 166: AC_ARG_WITH( Line 167: [smbios-osname], Line 168: [AS_HELP_STRING([--with-smbios-osname=NAME], Line 169: [SMBIOS OS name @<:@default=oVirt Node@:>@])], Line 170: [SMBIOS_OSNAME=${withval}], here you must have quotes Line 171: [SMBIOS_OSNAME='oVirt Node']) Line 172: AC_SUBST([SMBIOS_OSNAME]) Line 173: Line 174: # SASL username Line 167: [smbios-osname], Line 168: [AS_HELP_STRING([--with-smbios-osname=NAME], Line 169: [SMBIOS OS name @<:@default=oVirt Node@:>@])], Line 170: [SMBIOS_OSNAME=${withval}], Line 171: [SMBIOS_OSNAME='oVirt Node']) please use double quotes unless there is a reason for mixture. Line 172: AC_SUBST([SMBIOS_OSNAME]) Line 173: Line 174: # SASL username Line 175: AC_ARG_WITH( -- To view, visit http://gerrit.ovirt.org/30747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2854badc6b33073aa1d30e014172a3788057b5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
