Nir Soffer has posted comments on this change. Change subject: utils: Move functionality from storage.misc ......................................................................
Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/30850/3//COMMIT_MSG Commit Message: Line 6: Line 7: utils: Move functionality from storage.misc Line 8: Line 9: move rotateFiles into utils. Line 10: use ovirt node persist and unpersist in rotateFile. Please do not change anything in the code moved from misc in this patch! It is impossible to review such changes. If you want to support ovirt node, or change the logic, it must be in another patch. Line 11: Line 12: Change-Id: I091083caa868931fb3a0bcf3bc2df98091daee45 http://gerrit.ovirt.org/#/c/30850/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 187: os.rename(oldName, newName) Line 188: except: Line 189: pass Line 190: if isOvirtNode() and persist and not cp: Line 191: NodeCfg().persist(newName) this is not the original logic of the code moved from misc - move to anther patch. Line 192: Line 193: Line 194: def _parseMemInfo(lines): Line 195: """ -- To view, visit http://gerrit.ovirt.org/30850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I091083caa868931fb3a0bcf3bc2df98091daee45 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
