Nir Soffer has posted comments on this change. Change subject: utils: Move functionality from storage.misc ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/30850/3/vdsm/storage/multipath.py File vdsm/storage/multipath.py: Line 172: rc = misc.execCmd(cmd, sudo=True)[0] Line 173: if rc != 0: Line 174: raise se.MultipathSetupError() Line 175: if utils.isOvirtNode(): Line 176: NodeCfg().persist(self._MPATH_CONF) First, this is not related to moving code from misc to utils - move to another patch about supporting ovirt-node. Second, it does not make sense to check everywhere if we are running on ovirt-node - instead we should call utils.preristFile, which will do the right thing (nothing in not running on ovirt-node). Line 177: Line 178: # Flush all unused multipath device maps Line 179: misc.execCmd([constants.EXT_MULTIPATH, "-F"], sudo=True) Line 180: -- To view, visit http://gerrit.ovirt.org/30850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I091083caa868931fb3a0bcf3bc2df98091daee45 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
