Dan Kenigsberg has posted comments on this change. Change subject: utils: Move functionality from storage.misc ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30850/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 149: Line 150: logging.debug("dir: %s, prefixName: %s, versions: %s" % Line 151: (directory, prefixName, gen)) Line 152: gen = int(gen) Line 153: files = os.listdir(directory) Why overwrite the same variable? And what about my ps2 comments? I share Nir's opinion: it's better to move code in one patch, and fix it in another. But if you start fixing, please do it properly. Line 154: files = glob.glob("%s*" % prefixName) Line 155: fd = {} Line 156: for fname in files: Line 157: name = fname.rsplit('.', 1) -- To view, visit http://gerrit.ovirt.org/30850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I091083caa868931fb3a0bcf3bc2df98091daee45 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
