mooli tayer has posted comments on this change. Change subject: vdsm-tool: reorgenize module configurers. ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 32: Line 33: Line 34: __configurers = ( Line 35: libvirt.Libvirt(), Line 36: sanlock.Sanlock(), > can we dynamic scan the module for all classes that inherit from x? will look into it. different patch. Line 37: ) Line 38: Line 39: Line 40: @expose("configure") http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurators/__init__.py File lib/vdsm/tool/configurators/__init__.py: Line 41: # Line 42: CONFIGURED, NOT_CONFIGURED, NOT_SURE = range(3) Line 43: Line 44: Line 45: class ModuleConfigure(object): > unless this is vdsm project convention... I think this belongs to be within I don't mind, this was requested by Saggi. (since this is a sub module and it should be imported but import nothing) I will add him so he can respond too. Line 46: Line 47: def __init__(self): Line 48: pass Line 49: Line 45: class ModuleConfigure(object): Line 46: Line 47: def __init__(self): Line 48: pass Line 49: > add sort hint property? different patch. also sent an email about it. Line 50: def getName(self): Line 51: return None Line 52: Line 53: def getServices(self): -- To view, visit http://gerrit.ovirt.org/31400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic79d400760e425f6f4863b6a33c69aa14fb0c623 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
