Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: reorgenize module configurers. ......................................................................
Patch Set 1: -Code-Review (1 comment) just wondering.. where do we fix the certs bug? http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 71: if utils.isOvirtNode(): Line 72: if not os.path.exists(P_VDSM_CERT): Line 73: raise InvalidRun( Line 74: "vdsm: Missing certificate, vdsm not registered") Line 75: validate_ovirt_certs.validate_ovirt_certs() why do we validate the certs only for ovirt node? so how do we solve the certs issue here? Line 76: Line 77: # Remove a previous configuration (if present) Line 78: self.removeConf() Line 79: -- To view, visit http://gerrit.ovirt.org/31400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic79d400760e425f6f4863b6a33c69aa14fb0c623 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
