Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: reorgenize module configurers. ......................................................................
Patch Set 1: Code-Review+1 (2 comments) looks good. thanks. please inform yeela about those changes and follow her changes in http://gerrit.ovirt.org/30909 http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurators/Makefile.am File lib/vdsm/tool/configurators/Makefile.am: Line 1: # Line 2: # Copyright 2013 Hat, Inc. 2014 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurators/__init__.py File lib/vdsm/tool/configurators/__init__.py: Line 41: # Line 42: CONFIGURED, NOT_CONFIGURED, NOT_SURE = range(3) Line 43: Line 44: Line 45: class ModuleConfigure(object): > I don't mind, this was requested by Saggi. +1 Line 46: Line 47: def __init__(self): Line 48: pass Line 49: -- To view, visit http://gerrit.ovirt.org/31400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic79d400760e425f6f4863b6a33c69aa14fb0c623 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
