Dan Kenigsberg has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 324: self._conf = {} Line 325: self.name = name Line 326: Line 327: ni = netinfo.NetInfo() Line 328: network = tuple(ni.getBridgedNetworksAndVlansForIface(name)) This returns multiple of networks (and vlans) that use the "name" interface. Why do you take only the (random) first one? What is passed from Engine when iscsi is to use a vlan device? If the storage network is a non-VM network, but bridged networks exist over the interface, this function would not return the storage network at all. Line 329: Line 330: if network: Line 331: self._conf['iface.net_ifacename'] = network[0][0] Line 332: else: -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
