Dan Kenigsberg has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 325: self.name = name Line 326: Line 327: ni = netinfo.NetInfo() Line 328: network = tuple(ni.getBridgedNetworksAndVlansForIface(name)) Line 329: > Sounds fair enough. Abandoning this. Please don't abandon - whereever we find the interface to be used, we would have to set iface.net_ifacename here. For non-VM networks, it would be enough. Sergey, do we really need to pass both the bridge and its underlying interface from Engine? Wouldn't passing the bridge (which carries the IP address) be enough? Line 330: if network: Line 331: self._conf['iface.net_ifacename'] = network[0][0] Line 332: else: Line 333: self._conf['iface.net_ifacename'] = name -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
