Sergey Gotliv has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 325: self.name = name Line 326: Line 327: ni = netinfo.NetInfo() Line 328: network = tuple(ni.getBridgedNetworksAndVlansForIface(name)) Line 329: > I suspect that finding the top-level device won't be any easier in Engine, 1. Currently API gets a map/dictionary of parameters, so adding one more is not a problem. 2. Engine allow to configure ISCSI Bond based on the network not the low level device, later Engine calculates a NIC/Vlan related to the particular network in the scope of the Host so it should find all needed devices in the same place. 3. I think that Engine should keep all business logic including calculating of devices otherwise it looks awkward - Engine calculates a device based on the network, but later VDSM performs very similar calculations to complete the picture. Line 330: if network: Line 331: self._conf['iface.net_ifacename'] = network[0][0] Line 332: else: Line 333: self._conf['iface.net_ifacename'] = name -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
