Amador Pahim has posted comments on this change.

Change subject: Configure iSCSI iface.net_ifacename
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 325:         self.name = name
Line 326: 
Line 327:         ni = netinfo.NetInfo()
Line 328:         network = tuple(ni.getBridgedNetworksAndVlansForIface(name))
Line 329: 
> Can you, please, check iface.ipaddress as well? Existing VDSM code already 
Looks like iscsid does not accept it:

(/var/log/messages)
  Sep  1 16:39:59 rhevh01 iscsid: Cannot bind 192.168.25.200 to net/scsi 
interface. This is not supported with software iSCSI (iscsi_tcp).
  Sep  1 16:39:59 rhevh01 iscsid: cannot make a connection to 
192.168.25.118:3260 (-1,0)

And connection does not happen in fact.
Line 330:         if network:
Line 331:             self._conf['iface.net_ifacename'] = network[0][0]
Line 332:         else:
Line 333:             self._conf['iface.net_ifacename'] = name


-- 
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apa...@redhat.com>
Gerrit-Reviewer: Amador Pahim <apa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to